Dimension and Hilbert: handle zero ideal#105
Merged
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom Jun 18, 2025
Merged
Dimension and Hilbert: handle zero ideal#105mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
Conversation
Collaborator
|
Many thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
I chose here to adapt the function to handle this case instead of dealing with these cases separately.
The purpose is to strengthen the tests on these functions, by testing limit cases.
Efficiently speaking I think the difference is negligible.